Add read only ZipStore #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjkelly
reviewed
Oct 12, 2023
sjkelly
reviewed
Oct 12, 2023
Co-authored-by: Steve Kelly <[email protected]>
Pull Request Test Coverage Report for Build 5558541626Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
meggart
approved these changes
Feb 23, 2024
| for subdir in subdirs(s, p) | ||
| _writezip(w, s, _make_prefix(p)*subdir) | ||
| end | ||
| end |
There was a problem hiding this comment.
This is a very nice interface idea to produce zip stores.
| @@ -145,5 +216,35 @@ end | |||
| @test g2.attrs == Dict("groupatt"=>5) | |||
| @test g2["a1"].attrs == Dict("arratt"=>2.5) | |||
| @test g2["a1"][:,:] == reshape(1:200,10,20) | |||
|
|
|||
| # The following test doesn't pass, but maybe should? | |||
There was a problem hiding this comment.
Ok, I will check this later. Maybe we could make a broken test from it, let's see
|
Thanks a lot and sorry for missing this for such a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
ZipStore <: AbstractStoreandwritezipfunction.With these, zipped Zarr data can be written to any writeable
IOand read from anyAbstractVector{UInt8}This should be compatible with https://zarr.readthedocs.io/en/stable/api/storage.html#zarr.storage.ZipStore
Because zip files can behave differently when their size is over 4GB, this still needs to be tested with zarr-python for very large datasets.